chore(utxo-core): updated test and verify

TICKET: BTC-2047

Author: christopher-fong

modules/utxo-core/src/paygo/psbt/Errors.ts

@@ -22,22 +22,8 @@ export class ErrorOutputIndexOutOfBounds extends Error {
   }
 }
 
-export class ErrorProofAddressMismatchOutputAdress extends Error {
-  constructor(public addressFromProof: string, public addressFromOutput: string) {
-    super(
-      `The address from the output (${addressFromOutput}) does not match the address that is in the proof (${addressFromProof}).`
-    );
-  }
-}
-
 export class ErrorMultiplePayGoProofAtPsbtIndex extends Error {
   constructor(public outputIndex: number) {
     super(`There are multiple PayGo addresses in the PSBT output ${outputIndex}.`);
   }
 }
-
-export class ErrorPublicKeyMismatch extends Error {
-  constructor() {
-    super('The public key in the PSBT does not match the provided public key.');
-  }
-}

modules/utxo-core/src/paygo/psbt/PayGoUtils.ts

@@ -12,7 +12,7 @@ import {
 } from './Errors';
 
 /** This function adds the entropy and signature into the PSBT output unknown key vals.
- * We store the entropy so that we reconstruct the message <varint_len><entropy><address><uuid>
+ * We store the entropy so that we reconstruct the message <ENTROPY><ADDRESS><UUID>
  * to later verify.
  *
  * @param psbt - PSBT that we need to encode our paygo address into
@@ -35,7 +35,7 @@ export function addPayGoAddressProof(
   });
 }
 
-/** Verify the paygo address signature is valid using BitGoJs statics
+/** Verify the paygo address signature is valid using verification pub key.
  *
  * @param psbt - PSBT we want to verify that the paygo address is in
  * @param outputIndex - we have the output index that address is in

modules/utxo-core/test/paygo/psbt/PayGoUtils.ts

@@ -138,8 +138,8 @@ describe('getPaygoAddressProofIndex', () => {
   it('should return an error and fail if we have multiple PayGo address in the PSBT in the same output index', () => {
     const psbt = getTestPsbt();
     const outputIndex = 0;
-    addPayGoAddressProof(psbt, outputIndex, sig, Buffer.from(attestationPubKey));
-    addPayGoAddressProof(psbt, outputIndex, sig, Buffer.from('xpub12345abcdef29a028510d3b2d4'));
+    addPayGoAddressProof(psbt, outputIndex, sig, addressProofEntropy);
+    addPayGoAddressProof(psbt, outputIndex, sig, crypto.randomBytes(64));
     assert.throws(
       () => getPayGoAddressProofOutputIndex(psbt),
       (e: any) => e.message === 'There are multiple PayGo addresses in the PSBT output 0.'