From 9e7c22e24d1001a491d622de93c674c81cbf5df6 Mon Sep 17 00:00:00 2001 From: vishad-tyagi <78733360+vishad-tyagi@users.noreply.github.com> Date: Tue, 2 Apr 2024 16:12:34 +0530 Subject: [PATCH 1/2] Added iconColor to project_overflow_menu.dart --- ios/Podfile.lock | 2 +- .../src/components/project_overflow_menu.dart | 16 ++++++++++++---- .../lib/src/landing_page.dart | 7 ++++--- 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/ios/Podfile.lock b/ios/Podfile.lock index 62cb12ec..b124104e 100644 --- a/ios/Podfile.lock +++ b/ios/Podfile.lock @@ -140,4 +140,4 @@ SPEC CHECKSUMS: PODFILE CHECKSUM: a62623f56f2d1d0e85a4a3c73509cd2832d5c86f -COCOAPODS: 1.14.3 +COCOAPODS: 1.15.0 diff --git a/packages/features/landing_page_screen/lib/src/components/project_overflow_menu.dart b/packages/features/landing_page_screen/lib/src/components/project_overflow_menu.dart index 78d68833..f13cd269 100644 --- a/packages/features/landing_page_screen/lib/src/components/project_overflow_menu.dart +++ b/packages/features/landing_page_screen/lib/src/components/project_overflow_menu.dart @@ -17,9 +17,13 @@ enum ProjectOverflowMenuOption { class ProjectOverflowMenu extends ConsumerStatefulWidget { final Project project; + final Color? iconColor; - const ProjectOverflowMenu({Key? key, required this.project}) - : super(key: key); + const ProjectOverflowMenu({ + Key? key, + required this.project, + this.iconColor, + }) : super(key: key); @override ConsumerState createState() => @@ -39,9 +43,13 @@ class _ProjectOverFlowMenuState extends ConsumerState { loading: () {}, ); - return PopupMenuButton( + Widget icon = widget.iconColor != null + ? Icon(Icons.more_vert, color: widget.iconColor) + : const Icon(Icons.more_vert); + + return PopupMenuButton( color: Theme.of(context).colorScheme.background, - icon: const Icon(Icons.more_vert), + icon: icon, shape: RoundedRectangleBorder( side: const BorderSide(), borderRadius: BorderRadius.circular(20), diff --git a/packages/features/landing_page_screen/lib/src/landing_page.dart b/packages/features/landing_page_screen/lib/src/landing_page.dart index 35c2690f..05ca61b5 100644 --- a/packages/features/landing_page_screen/lib/src/landing_page.dart +++ b/packages/features/landing_page_screen/lib/src/landing_page.dart @@ -232,9 +232,10 @@ class _ProjectPreview extends StatelessWidget { child: latestModifiedProject == null ? null : ProjectOverflowMenu( - key: const Key('ProjectOverflowMenu Key0'), - project: latestModifiedProject!, - ), + key: const Key('ProjectOverflowMenu Key0'), + project: latestModifiedProject!, + iconColor: const Color(0xFF191C1D), + ), ), ], ); From 1b774d78721c57b7739b7836a00a013fe5199216 Mon Sep 17 00:00:00 2001 From: vishad-tyagi <78733360+vishad-tyagi@users.noreply.github.com> Date: Sun, 21 Apr 2024 13:58:07 +0530 Subject: [PATCH 2/2] Added iconColor to project_overflow_menu.dart --- .../lib/src/components/project_overflow_menu.dart | 2 +- packages/features/landing_page_screen/lib/src/landing_page.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/features/landing_page_screen/lib/src/components/project_overflow_menu.dart b/packages/features/landing_page_screen/lib/src/components/project_overflow_menu.dart index f13cd269..fed3d259 100644 --- a/packages/features/landing_page_screen/lib/src/components/project_overflow_menu.dart +++ b/packages/features/landing_page_screen/lib/src/components/project_overflow_menu.dart @@ -52,7 +52,7 @@ class _ProjectOverFlowMenuState extends ConsumerState { icon: icon, shape: RoundedRectangleBorder( side: const BorderSide(), - borderRadius: BorderRadius.circular(20), + borderRadius: BorderRadius.circular(20.0), ), onSelected: _handleSelectedOption, itemBuilder: (BuildContext context) => ProjectOverflowMenuOption.values diff --git a/packages/features/landing_page_screen/lib/src/landing_page.dart b/packages/features/landing_page_screen/lib/src/landing_page.dart index 05ca61b5..59dc7aee 100644 --- a/packages/features/landing_page_screen/lib/src/landing_page.dart +++ b/packages/features/landing_page_screen/lib/src/landing_page.dart @@ -234,7 +234,7 @@ class _ProjectPreview extends StatelessWidget { : ProjectOverflowMenu( key: const Key('ProjectOverflowMenu Key0'), project: latestModifiedProject!, - iconColor: const Color(0xFF191C1D), + iconColor: lightColorScheme.onBackground, ), ), ],