Skip to content

Step index won't work for 50-01 #94

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
weerox opened this issue Jul 24, 2017 · 6 comments
Open

Step index won't work for 50-01 #94

weerox opened this issue Jul 24, 2017 · 6 comments
Labels

Comments

@weerox
Copy link
Contributor

weerox commented Jul 24, 2017

Website-link:
https://coderdojopotsdam.github.io/regex-tutorial/en/50-01.html
https://coderdojopotsdam.github.io/regex-tutorial/de/50-01.html

Expected Behavior

It should display 46 in the last bubble. (And have a black background).

Actual Behavior

It has a green background and there are no index number.

Actions to Reproduce

Visit any of the above links.

Solution Description

It seems like the link is missing the "current" class, but I don't know why.

Hints

Take a look at tutorial.html. The problem should be in there somewhere, probably somewhere in the loop.

@joshhazelhurst123
Copy link
Contributor

@weerox I had a good look and had no success. Could not find "current" class either. Not sure why the file jumps from 13-02.html to 50-01.html
Line 93 of tutorial.html is confusing.

@niccokunzmann
Copy link
Member

niccokunzmann commented Aug 1, 2017

This is interesting

  • it works on my computer when I build it locally.
  • I see it is missing in the browser
    grafik

8bdc7c2 is also the last commit here: https://github.com/CoderDojoPotsdam/regex-tutorial/commits/master
I see it but I can not reproduce it.

@weerox
Copy link
Contributor Author

weerox commented Aug 2, 2017

Weird. Checked again to be sure, but I still can't see the number...

@niccokunzmann
Copy link
Member

@weerox I corrected my comment to be more clear that I can only see the content when I build it on my conputer using jekyll.

I think, this is a minor issue which can cost a lot of energy. So I will not work on it.

@niccokunzmann
Copy link
Member

Hm. Maybe we can reproduce it when we use the github gem instead of just jekyll. https://github.com/github/pages-gem

@niccokunzmann
Copy link
Member

It is reproducable using the github pages gem
grafik
To reproduce, you can use the github-pages-gem branch or merge #101 and use master.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants