Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace I18n ids with constants #20

Open
CrissNamon opened this issue Mar 28, 2023 · 1 comment · May be fixed by #45
Open

Replace I18n ids with constants #20

CrissNamon opened this issue Mar 28, 2023 · 1 comment · May be fixed by #45
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@CrissNamon
Copy link
Owner

CrissNamon commented Mar 28, 2023 •
edited
Loading

Replace strings like:

I18nUtils.get("alert.unsaved.header");

with constants:

public static final String ALERT_UNSAVED_HEADER = I18nUtils.get(ALERT_UNSAVED_HEADER);
@CrissNamon CrissNamon added enhancement New feature or request good first issue Good for newcomers labels Mar 28, 2023
@CrissNamon
Copy link
Owner Author

Replace I18n ids with constants

@coderr19 coderr19 mentioned this issue Mar 29, 2023
Closed
@CrissNamon CrissNamon linked a pull request Mar 30, 2023 that will close this issue
Replaced I18n ids #31
Closed
@CrissNamon CrissNamon removed a link to a pull request Apr 5, 2023
Replaced I18n ids #31
Closed
@innodax innodax linked a pull request May 11, 2024 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace I18n ids with constants done innodax/compaj
1 participant
@CrissNamon