add rubocop-performance

Author: Dahie

.rubocop.yml

@@ -3,6 +3,7 @@ inherit_from: .rubocop_todo.yml
 require:
   - rubocop-rake
   - rubocop-rspec
+  - rubocop-performance
 
 AllCops:
   NewCops: enable

Gemfile

@@ -12,5 +12,6 @@ gem 'guard-rspec'
 gem 'rake'
 gem 'rspec'
 gem 'rubocop'
+gem 'rubocop-performance'
 gem 'rubocop-rake'
 gem 'rubocop-rspec'

Gemfile.lock

@@ -118,6 +118,9 @@ GEM
       rubocop (~> 1.41)
     rubocop-factory_bot (2.25.1)
       rubocop (~> 1.41)
+    rubocop-performance (1.18.0)
+      rubocop (>= 1.7.0, < 2.0)
+      rubocop-ast (>= 0.4.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
     rubocop-rspec (2.27.0)
@@ -147,6 +150,7 @@ DEPENDENCIES
   rake
   rspec
   rubocop
+  rubocop-performance
   rubocop-rake
   rubocop-rspec
 

lib/caramelize/filters/camel_case_to_wiki_links.rb

@@ -18,8 +18,8 @@ def run
     private
 
     def format_link(link)
-      link.gsub!(' ', '_')
-      link.gsub!('.', '')
+      link.tr!(' ', '_')
+      link.delete!('.')
       "[[#{link}]]"
     end
   end

lib/caramelize/filters/swap_wiki_links.rb

@@ -20,8 +20,8 @@ def run
 
     def format_link(label, link)
       link.downcase!
-      link.gsub!(' ', '_')
-      link.gsub!('.', '')
+      link.tr!(' ', '_')
+      link.delete!('.')
       "[[#{label}|#{link}]]"
     end
   end

lib/caramelize/input_wiki/redmine_wiki.rb

@@ -24,7 +24,7 @@ def read_pages
           build_page(row_page)
         end
         titles.uniq!
-        revisions.sort! { |a, b| a.time <=> b.time }
+        revisions.sort_by!(&:time)
 
         revisions
       end
@@ -43,12 +43,12 @@ def read_authors
       def build_page(row_page)
         results_contents = database.query(single_page_query(row_page['id']))
 
-        wiki = wikis.select { |row| row['id'] == row_page['wiki_id'] }.first
+        wiki = wikis.find { |row| row['id'] == row_page['wiki_id'] }
 
         project_identifier = ''
 
         if wiki
-          project = projects.select { |row| row['id'] == wiki['project_id'] }.first
+          project = projects.find { |row| row['id'] == wiki['project_id'] }
           project_identifier = "#{project['identifier']}/"
         end
 

lib/caramelize/input_wiki/wiki.rb

@@ -17,7 +17,7 @@ def revisions_by_title(title)
         # new array only containing pages by this name sorted by time asc
         # this does not support renamed pages
         revisions.select { |revision| revision.title == title }
-                 .sort { |x, y| x.time <=> y.time }
+                 .sort_by(&:time)
       end
 
       # return an empty array in case this action was not overridden
@@ -54,7 +54,7 @@ def filters
       end
 
       def latest_revisions
-        @latest_revisions ||= titles.map { |title| revisions_by_title(title).last }.compact
+        @latest_revisions ||= titles.filter_map { |title| revisions_by_title(title).last }
       end
 
       def markup

lib/caramelize/output_wiki/gollum.rb

@@ -38,7 +38,7 @@ def rename_page(page_title, new_title)
       def commit_history(revisions, options = {}, &block)
         revisions.each_with_index do |page, index|
           # call debug output from outside
-          block.call(page, index) if block_given?
+          yield(page, index) if block
           commit_revision(page, options.fetch(:markup, :markdown))
         end
       end