Skip to content

🐛 [Bug]: Anchor组件滚动事件没有销毁 #120

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
huangshuaige opened this issue Dec 29, 2021 · 0 comments · May be fixed by #1889
Open

🐛 [Bug]: Anchor组件滚动事件没有销毁 #120

huangshuaige opened this issue Dec 29, 2021 · 0 comments · May be fixed by #1889
Assignees
@fu050409
Labels
bug Something isn't working

Comments

@huangshuaige
Copy link

Version

0.0.1

Vue Version

3.1.1

Link to minimal reproduction

https://vue-devui.github.io/components/anchor/

Step to reproduce

在看源码的时候发现的，不知道是不是这样设计的,后来去看了下angular版本确实是没有销毁，从Anchor生成的时候用了window.onscroll,组件销毁的时候没做任何处理

What is expected

window.onscroll = null

What is actually happening

No response

Any additional comments (optional)

No response
@huangshuaige huangshuaige added the bug Something isn't working label Dec 29, 2021
fu050409 added a commit to SWPUOpenSource/vue-devui that referenced this issue Jun 18, 2024
@fu050409
fix(anchor): remove listeners when component destroyed
1de2f9c 
- Fixed some spelling mistakes in the code.
- Add unmounted method.
- Remove all listeners when unmounted.

Resolves: DevCloudFE#120
@fu050409 fu050409 linked a pull request Jun 18, 2024 that will close this issue
Open
@fu050409 fu050409 self-assigned this Jun 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@fu050409 fu050409

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(anchor): remove listeners when component destroyed SWPUOpenSource/vue-devui
2 participants
@fu050409 @huangshuaige