Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Possible problems when using both this and Firebase plugin on android #183

Open
PeterStaev opened this issue Feb 13, 2020 · 4 comments
Open

Comments

@PeterStaev
Copy link

PeterStaev commented Feb 13, 2020

It seems there is is a problem when using both LocalNotifications and Firebase plugins in the same app under android. And more specifically if you kill the app and then respond via an action, the local notification handler is not triggered. In all other cases - when the app is in either foreground or background seems the callback is correctly triggered.
It is probably something similar to #107

@edusperoni
Copy link
Contributor

I wrote https://github.com/edusperoni/nativescript-shared-notification-delegate for this exact reason. My PRs with the fixes are on both repos and allow any library to share a single delegate (interception is also possible):

EddyVerbruggen/nativescript-plugin-firebase#1272
#155

@saeb-panahifar helped test and validate the fixes, just waiting on @EddyVerbruggen to merge them.

@PeterStaev
Copy link
Author

@edusperoni your PRs are for iOS, this is for android 😉

@edusperoni
Copy link
Contributor

I see. You should probably add that to the issue description, as #107 is describing the iOS scenario.

@EddyVerbruggen
Copy link
Owner

FYI the related iOS issue in this repo (and the Firebase one) is in my list of open tabs in Chrome. Trying to find some time every day to get this processed. I think I'll just merge them because they've already been tested. @edusperoni many thanks for your efforts!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants