Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[sfDoctrinePlugin] When merge schema files global parameters are not deep merged like Doctrine1 #196

Open
alquerci opened this issue Jul 21, 2018 · 0 comments

Comments

@alquerci
Copy link
Contributor

alquerci commented Jul 21, 2018

This bug provide a different behaviour than Doctrine1:

https://github.com/LExpress/doctrine1/blob/v1.3.6/lib/Doctrine/Import/Schema.php#L330

How to reproduce?

connection: doctrine
options:
  charset: utf8

Foo:
  options:
    symfony:
      form: false

Expected

Foo:
  connection: doctrine
  options:
    charset: utf8
    symfony:
      form: false

Actual

Foo:
  connection: doctrine
  options:
    symfony:
      form: false

Track for fix

Using a deep merge instead of the simple array_merge() function can be a solution.

@alquerci alquerci changed the title [sfDoctrinePlugin] When merge schema files global parameters are not deep merged like Doctrine1 done [sfDoctrinePlugin] When merge schema files global parameters are not deep merged like Doctrine1 does Aug 13, 2018
@alquerci alquerci changed the title [sfDoctrinePlugin] When merge schema files global parameters are not deep merged like Doctrine1 does [sfDoctrinePlugin] When merge schema files global parameters are not deep merged like Doctrine1 Aug 13, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant