Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[github] improve cs fixer configuration #329

Open
connorhu opened this issue Feb 19, 2024 · 0 comments
Open

[github] improve cs fixer configuration #329

connorhu opened this issue Feb 19, 2024 · 0 comments

Comments

@connorhu
Copy link
Collaborator

connorhu commented Feb 19, 2024

It should be smart about three things:

  • it should only check files that have changed (my original PR knew this, but the ability was lost somewhere)
  • it should filter which violations can stay based on the PR patch. In the case of a positive PR statistic, only the violation in the rows affected by the PR can remain:
    diff
  • location of violation should be well marked.
@thePanz thePanz mentioned this issue Mar 18, 2024
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant