Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sfCombinePlugin #383

Open
Adz10kvtech opened this issue Feb 3, 2025 · 3 comments
Open

sfCombinePlugin #383

Adz10kvtech opened this issue Feb 3, 2025 · 3 comments

Comments

@Adz10kvtech
Copy link

Issue with php 8

146 : return $path{0} == '/' ? '/' . $normalizedPath : $normalizedPath;

change to 146 : return $path[0] == '/' ? '/' . $normalizedPath : $normalizedPath;

@thePanz
Copy link
Member

thePanz commented Feb 14, 2025

@Adz10kvtech is this a 3rd party plugin?

Can you point me to the file in this repo affected by your suggestion?

@Adz10kvtech
Copy link
Author

Yeah, it was a third-party plugin from the old 1.4 days.

https://github.com/heristop/sf-combine-plugin

The issue was with https://github.com/heristop/sf-combine-plugin/blob/master/lib/sfCombineUtility.class.php line 146.

@thePanz
Copy link
Member

thePanz commented Feb 26, 2025

Let me know if you're interested in moving that plugin under the friendsOfSymfony1 organization and help maintaining it :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants