Update .NET client library to re-use HTTPClient per host

[mooreds]

Update .NET client library to re-use HTTPClient per host

Problem

Want to be able to re-use HTTPClients

Solution

PR submitted in the netcore client lib project.

Alternatives/workarounds

n/a

Additional context

Originally filed here: FusionAuth/fusionauth-netcore-client#61 , putting in fusionauth-issues for visibility.

Community guidelines

All issues filed in this repository must abide by the FusionAuth community guidelines.

How to vote

Please give us a thumbs up or thumbs down as a reaction to help us prioritize this feature. Feel free to comment if you have a particular need or comment on how this feature should work.

[Pycnomerus]

even though this does work, it's not a solution that match all use case and doesn't fix the inital problem, being you do not have control on the HttpClient instance used.

I opened a pr for doing this in c# a few weaks ago.

FusionAuth/fusionauth-netcore-client@a8d4840

that way you can leverage the IHttpClientFactory to reuse HttpClients. regardless of if you use DI or not.

[stadion-ianjones]

I would like to see more control over the HttpClient as well,
e.g. to be able to set the Timeout on the HttpClient, control the lifecycle as per MS recommendations https://learn.microsoft.com/en-us/dotnet/fundamentals/networking/http/httpclient-guidelines
But I agree it followed standard AddHttpClient, I can then use AddPolicyHandler to utilize a Polly policy, for timeouts, retries, circuit breaker.
Summary

• better control of lifecycle of HttpClient
• control of DNS lookup when HttpClient re-used
• control of HttpClient timeout
• ability to utilise AddPolicyHandler to add Polly policies, by making use of IHttpClientBuilder