Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Gradient tool selects end point on mouse up #2445

Open
0HyperCube opened this issue Mar 16, 2025 · 0 comments · May be fixed by #2472
Open

Gradient tool selects end point on mouse up #2445

0HyperCube opened this issue Mar 16, 2025 · 0 comments · May be fixed by #2472
Labels
Good First Issue Good for newcomers Paper Cut A small UX annoyance we should strive to improve

Comments

@0HyperCube
Copy link
Member

Reproduce:

  • Draw gradient
  • Try and select a non-end point (i.e. the start or middle)
broken_gradient_selection.mp4

This is because in the (GradientToolFsmState::Drawing, GradientToolMessage::PointerUp) FSM transition, the SelectedGradient::new is called, which sets the selected point to the end one. A regression introduced by #1945.
@0HyperCube 0HyperCube added Good First Issue Good for newcomers Paper Cut A small UX annoyance we should strive to improve labels Mar 16, 2025
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Mar 16, 2025
@Sidharth-Singh10 Sidharth-Singh10 linked a pull request Mar 19, 2025 that will close this issue
Open
@0HyperCube 0HyperCube mentioned this issue Mar 25, 2025
Open
6 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Good First Issue Good for newcomers Paper Cut A small UX annoyance we should strive to improve
Projects
Task Board
Status: Short-Term
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix gradient tool incorrectly selecting end point on pointer up Sidharth-Singh10/Graphite
1 participant
@0HyperCube