Skip to content

related_urls match too much #22

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
Natureshadow opened this issue Nov 16, 2020 · 0 comments · May be fixed by #25
Open

related_urls match too much #22

Natureshadow opened this issue Nov 16, 2020 · 0 comments · May be fixed by #25

Comments

@Natureshadow
Copy link
Contributor

The new related_urls feature matches too much, i.e. in the middle of a string.

Giving /car as related URL will not only match /car/1, but also /drinks/categories/carbonated. Using a trailing / would help a bit, but that would mean that /person is not matched under all circumstances.
Natureshadow added a commit to Natureshadow/django-menu-generator that referenced this issue Nov 16, 2020
@Natureshadow
Anchor related_url to beginning of request path
1f8f34b 
Closes LaLogiaDePython#22.
@Natureshadow Natureshadow linked a pull request Nov 16, 2020 that will close this issue
Open
Natureshadow added a commit to Natureshadow/django-menu-generator that referenced this issue Nov 17, 2020
@Natureshadow
Anchor related_url to beginning of request path and match components
f77cc68 
Closes LaLogiaDePython#22.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Anchor related_url to beginning of request path Natureshadow/django-menu-generator
1 participant
@Natureshadow