default flags for remove_raw_by_flags should not remove ACQ_IS_PARALLEL_CALIBRATION

[aTrotier]

The pipeline for MRD acquisition generally looks like :

f = MRIFiles.ISMRMRDFile(path_mrd)
raw = RawAcquisitionData(f)
raw2 = MRIBase.remove_raw_by_flags(raw)
raw3 = remove_oversampling(raw2)

acq = AcqusitionData(raw3)
acq_cc,_ = softwareCoilCompression(acq,10);

maps = espirit(acq_cc, (6, 6, 6), 24)

However, the default parameters for remove_raw_by_flags ->

["ACQ_IS_NOISE_MEASUREMENT", "ACQ_IS_PARALLEL_CALIBRATION", "ACQ_IS_NAVIGATION_DATA", "ACQ_IS_PHASECORR_DATA", "ACQ_IS_DUMMYSCAN_DATA", "ACQ_IS_PHASE_STABILIZATION_REFERENCE", "ACQ_IS_PHASE_STABILIZATION"])

parallel_calibration profiles are removed but they are required to estimates espirit. (Only ACQ_IS_PARALLEL_CALIBRATION_AND_IMAGING are used)

Should I :

1. Remove the default value and let the user figure out what flags should be removed
2. Keep things like that and add in the doc an example which separate calibration data

f = MRIFiles.ISMRMRDFile(path_mrd)
raw = RawAcquisitionData(f)
raw_cal = filter_raw_by_flags(raw,["ACQ_IS_PARALLEL_CALIBRATION","ACQ_IS_PARALLEL_CALIBRATION_AND_IMAGING"])
raw_cal = remove_oversampling(raw_cal)

acq_cal = AcqusitionData(raw_cal)
acq_cal_cc,_ = softwareCoilCompression(acq_cal,10);

maps = espirit(acq_cal_cc, (6, 6, 6), 24)

3. Remove "ACQ_IS_PARALLEL_CALIBRATION" from default value ?

[aTrotier]

Actually it should be :

raw_cal = filter_raw_by_flags(raw,"ACQ_IS_PARALLEL_CALIBRATION")
raw_cal2 = filter_raw_by_flags(raw,"ACQ_IS_PARALLEL_CALIBRATION_AND_IMAGING")
push!(raw_cal.profiles,raw_cal2.profiles...)

raw_cal = filter_raw_by_flags(raw,["ACQ_IS_PARALLEL_CALIBRATION","ACQ_IS_PARALLEL_CALIBRATION_AND_IMAGING"]) returns profile with both flags

Maybe my interface is not the best 👎