Simplify DialogHost.Show API

[corvinsz]

I was recently checking out what it would take to add a fullscreen DialogHost. With a basic PoC I ended up adding a new parameter to the DialogHost.Show method. This clutters the Show(..) methods on the DialogHost even more.
Thoughts on adding a new class which bundles all the parameters the consumer can pass into the Show() methods? They have done the same in MudBlazors Dialog.

It would remove the method-clutter we currently have, and in my opinion improve discoverability, because you wouldn't have to look through so many method overloads and optional parameters.

The new API could look something like this

New DialogOptions class:

public class DialogOptions
{
    public object Content { get; set; }
    public string? Identifier { get; set; }
    public object DialogIdentifier { get; set; }
    public DialogOpenedEventHandler? OpenedEventHandler { get; set; }
    public DialogClosingEventHandler? ClosingEventHandler { get; set; }
    public DialogClosedEventHandler? ClosedEventHandler { get; set; }
}

New DialogHost.Show API:

public static Task<object?> Show(DialogOptions options)
{
    // The ShowInternal() method goes here...
}

If the above ends up being a thing, we should probably mark the current Show(..) methods as Obsolete for a few versions.

[Keboo]

I agree, and that sort of Options based pattern is quite common in several Microsoft libraries as well, especially for we want to be able to add additional options. I think some of the overloads should probably stay and convenience methods and simply call the overload that takes the DialogOptions, but would probably need to review that on a case-by-case basis.

[nicolaihenriksen]

I am also a fan of the Options pattern, so I definitely support this 👍