Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Some Improvements #12

Open
mrcwbr opened this issue Jan 2, 2021 · 0 comments
Open

Some Improvements #12

mrcwbr opened this issue Jan 2, 2021 · 0 comments

Comments

@mrcwbr
Copy link

mrcwbr commented Jan 2, 2021

I'm using your picker and It's really great. But I have some improvements that'd be nice:

  1. Render without a child: I control the open state programmatically (not via user interaction) so it would be nice to include the picker without the default button. I currently use the following workaround to stop rendering the default "show"-button:
    <DateRangePicker onChange={this.setDates} endDate={endDate} startDate={startDate} displayedDate={displayedDate} open={isDatePickerOpen} range> <></> </DateRangePicker>

  2. Support of TypeScript would be nice (add a typescript declaration file and link it in you package.json - I think this should work: https://stackoverflow.com/a/51573845/6003494)

  3. OnBackdropClick-Handler (clicking the backdrop (Black Background when the calendar is open) should fire an event, so I can handle it in my app)

If I have time the next days and you like the ideas I can contribute a PR for this issue.

Best regards
Marco

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant