From 1bf29cb2f6c0ffabd152f14187d0af4f35a8d109 Mon Sep 17 00:00:00 2001 From: Daniel Teixeira Date: Tue, 20 Aug 2024 15:19:33 -0300 Subject: [PATCH] Fix Circular Reference Issue and Ensure Correct Path for Chromium Build --- src/nopecha/extension/extension.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/nopecha/extension/extension.py b/src/nopecha/extension/extension.py index 6fcb8da..3e41a90 100644 --- a/src/nopecha/extension/extension.py +++ b/src/nopecha/extension/extension.py @@ -53,10 +53,10 @@ def build( raise RuntimeError(f"Could not find download link for {branch}") if outpath.exists(): - manifest = loads((outpath / "manifest.json").read_text()) - if manifest["version_name"] != latest_release["tag_name"]: + manifest_file = loads((outpath / "manifest.json").read_text()) + if manifest_file["version_name"] != latest_release["tag_name"]: print( - f"[NopeCHA] {latest_release['tag_name']} is available, you got {manifest['version_name']}" + f"[NopeCHA] {latest_release['tag_name']} is available, you got {manifest_file['version_name']}" ) download_release(download_url, outpath) @@ -64,13 +64,13 @@ def build( print(f"[NopeCHA] Downloading {latest_release['tag_name']}") download_release(download_url, outpath) - manifest = loads((outpath / "manifest.json").read_text()) - manifest["nopecha"].update(manifest) - (outpath / "manifest.json").write_text(dumps(manifest, indent=2)) + manifest_file = loads((outpath / "manifest.json").read_text()) + manifest_file["nopecha"].update(manifest) + (outpath / "manifest.json").write_text(dumps(manifest_file, indent=2)) print(f"[NopeCHA] Built {branch} extension to {outpath}") - return str(outpath) + return str(outpath.absolute()) def build_chromium( @@ -82,4 +82,4 @@ def build_chromium( def build_firefox( manifest: typing.Dict[str, typing.Any], outpath: typing.Optional[Path] = None ) -> str: - return build("firefox", manifest, outpath) + return build("firefox", manifest, outpath) \ No newline at end of file