fixed #8 chnage return type of filebin fucntion

Author: Joungkyun

README.md

@@ -38,12 +38,17 @@ extension = /path/filebin.so
 
 ## Proto types:
 ```php
-filebin (string path, int flag = MAGIC_NONE, string magic_path = MIGIC_FILE): string|NULL
-filebin (string path, string magic_path = MIGIC_FILE, int flag = MAGIC_NONE): string|NULL
+filebin (string path, int flag = MAGIC_NONE, string magic_path = MIGIC_FILE): string|false
+filebin (string path, string magic_path = MIGIC_FILE, int flag = MAGIC_NONE): string|false
 ```
 
 The 2th argument and the 3th argument can be swapped with each other.
 
+**Return value :**
+if success, return mime strings.
+if failure, return false.
+
+
 ## Constant
 Name | Value
 -- | --
@@ -87,7 +92,7 @@ Name | Description
 **Most common usage** :
 ```php
 <?php
-if ( ($buf = filebin ('modules/filebin.so')) != null )
+if ( ($buf = filebin ('modules/filebin.so')) != false )
     echo "$buf\n";
 ?>
 
@@ -98,7 +103,7 @@ ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, Buil
 **Execute with custom MAGIC file** :
 ```php
 <?php
-if ( ($buf = filebin ('modules/filebin.so', '/usr/share/misc/magic.mgc')) != null )
+if ( ($buf = filebin ('modules/filebin.so', '/usr/share/misc/magic.mgc')) != false )
     echo "$buf\n";
 ?>
 
@@ -108,7 +113,7 @@ ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, Buil
 
 **Get only file mime type** :
 ```php
-if ( ($buf = filebin ('modules/filebin.so', MAGIC_MIME_ENCODING)) != null )
+if ( ($buf = filebin ('modules/filebin.so', MAGIC_MIME_ENCODING)) != false )
     echo "$buf\n";
 ?>
 
@@ -118,7 +123,7 @@ binary
 
 **Get only file mime type with custom MAGIC file** :
 ```php
-if ( ($buf = filebin ('modules/filebin.so', MAGIC_MIME, '/usr/share/misc/magic.mgc')) != null )
+if ( ($buf = filebin ('modules/filebin.so', MAGIC_MIME, '/usr/share/misc/magic.mgc')) != false )
     echo "$buf\n";
 ?>
 
@@ -128,7 +133,7 @@ application/x-sharedlib; charset=binary
 
 **Can enable to swap 2th and 3th argument each other** :
 ```php
-if ( ($buf = filebin ('modules/filebin.so', MAGIC_MIME, '/usr/share/misc/magic.mgc')) != null )
+if ( ($buf = filebin ('modules/filebin.so', MAGIC_MIME, '/usr/share/misc/magic.mgc')) != false )
     echo "$buf\n";
 ?>
 

filebin.c

@@ -151,7 +151,8 @@ PHP_MINIT_FUNCTION(filebin)
 }
 /* }}} */
 
-/* {{{ proto (int|null) filebin(string path, array args_arr, int argc)
+/* {{{ proto filebin(string path[, int flag[, string magic-path]]): string|false
+ *     proto filebin(string path[, string magic-path[, int flag]]): string|false
  */
 PHP_FUNCTION(filebin) {
 	zval         * zflag;
@@ -183,12 +184,12 @@ PHP_FUNCTION(filebin) {
 
 	if ( ZSTR_LEN (path) == 0 ) {
 		php_error (E_WARNING, "The value of 1st argument was empty.");
-		RETURN_NULL ();
+		RETURN_FALSE;
 	}
 
 	if ( stat (ZSTR_VAL (path), &filestat) != 0 ) {
 		php_error (E_WARNING, "%s file not found.", ZSTR_VAL (path));
-		RETURN_NULL ();
+		RETURN_FALSE;
 	}
 
 	if ( fargs == 2 ) {
@@ -204,7 +205,7 @@ PHP_FUNCTION(filebin) {
 				break;
 			default :
 				php_error (E_WARNING, "2th argument is only available for integer(flag) or MAGIC file path.");
-				RETURN_NULL ();
+				RETURN_FALSE;
 		}
 	} else if ( fargs == 3 ) {
 		if ( Z_TYPE_P (zflag) == IS_LONG && Z_TYPE_P(zpath) == IS_STRING ) {
@@ -215,7 +216,7 @@ PHP_FUNCTION(filebin) {
 			mpath = Z_STRLEN_P (zflag) ? Z_STRVAL_P (zflag) : MAGIC;
 		} else {
 			php_error (E_WARNING, "The 2th and 3th argument can only be integer or strings.");
-			RETURN_NULL ();
+			RETURN_FALSE;
 		}
 	}
 
@@ -225,19 +226,19 @@ PHP_FUNCTION(filebin) {
 	magic = magic_open (flag);
 	if ( magic == NULL ) {
 		php_error (E_WARNING, strerror (errno));
-		RETURN_NULL ();
+		RETURN_FALSE;
 	}
 
 	if ( magic_load (magic, mpath) == -1 ) {
 		php_error (E_WARNING, magic_error (magic));
 		magic_close (magic);
-		RETURN_NULL ();
+		RETURN_FALSE;
 	}
 
 	if ( (type = magic_file (magic, ZSTR_VAL (path))) == NULL ) {
 		php_error (E_WARNING, magic_error(magic));
 		magic_close (magic);
-		RETURN_NULL ();
+		RETURN_FALSE;
 	}
 
 	RETVAL_STRING (type);

filebin.stub.php

@@ -2,4 +2,4 @@
 
 /** @generate-function-entries **/
 
-function filebin(string $path, int|string $flag = MAGIC_NONE, string|int $magic_path = MAGIC_FILE): string|null { }
+function filebin(string $path, int|string $flag = MAGIC_NONE, string|int $magic_path = MAGIC_FILE): string|false { }

filebin_arginfo.h

@@ -2,7 +2,7 @@
  * Stub hash: d70564e573467b0001913faa6501b6bfbbf066a2 */
 
 #if PHP_VERSION_ID >= 80000
-ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_filebin, 0, 1, MAY_BE_STRING|MAY_BE_NULL)
+ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_filebin, 0, 1, MAY_BE_STRING|MAY_BE_FALSE)
 	ZEND_ARG_TYPE_INFO(0, path, IS_STRING, 0)
 	ZEND_ARG_TYPE_MASK(0, flag, MAY_BE_LONG|MAY_BE_STRING, "MAGIC_NONE or MAGIC_FILE")
 	ZEND_ARG_TYPE_MASK(0, magic_path, MAY_BE_STRING|MAY_BE_LONG, "MAGIC_FILE or MAGIC_NONE")

tests/002-1arg.phpt

@@ -12,7 +12,7 @@ if ( ! extension_loaded ('filebin') ) {
 --FILE--
 <?php
 
-if ( filebin ('modules/filebin.so') == null )
+if ( filebin ('modules/filebin.so') == false )
 	echo 'skip';
 else
 	echo "filebin ('modules/filebin.so') success";

tests/003-user-magicfile.phpt

@@ -11,7 +11,7 @@ if ( ! extension_loaded ('filebin') ) {
 --INI--
 --FILE--
 <?php
-if ( filebin ('modules/filebin.so', '/usr/share/misc/magic.mgc') == null )
+if ( filebin ('modules/filebin.so', '/usr/share/misc/magic.mgc') == false )
 	echo 'skip';
 else
 	echo "using user magic file success";

tests/004-with-flag.phpt

@@ -12,7 +12,7 @@ if ( ! extension_loaded ('filebin') ) {
 --FILE--
 <?php
 
-if ( filebin ('modules/filebin.so', MAGIC_MIME_ENCODING) == null )
+if ( filebin ('modules/filebin.so', MAGIC_MIME_ENCODING) == false )
 	echo 'skip';
 else
 	echo "using with MAGIC_MIME_ENCODING flag success";

tests/005-flag-magicfile.phpt

@@ -12,7 +12,7 @@ if ( ! extension_loaded ('filebin') ) {
 --FILE--
 <?php
 
-if ( filebin ('modules/filebin.so', MAGIC_MIME, '/usr/share/misc/magic.mgc') == null )
+if ( filebin ('modules/filebin.so', MAGIC_MIME, '/usr/share/misc/magic.mgc') == false )
 	echo 'skip';
 else
 	echo "success";

tests/006-magicfile-flag.phpt

@@ -12,7 +12,7 @@ if ( ! extension_loaded ('filebin') ) {
 --FILE--
 <?php
 
-if ( filebin ('modules/filebin.so', '/usr/share/misc/magic.mgc', MAGIC_MIME) == null )
+if ( filebin ('modules/filebin.so', '/usr/share/misc/magic.mgc', MAGIC_MIME) == false )
 	echo 'skip';
 else
 	echo "success";