Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Missing ethernet padding remove while reassemble small fragment #1670

Open
chrhong opened this issue Sep 20, 2022 · 0 comments
Open

Missing ethernet padding remove while reassemble small fragment #1670

chrhong opened this issue Sep 20, 2022 · 0 comments

Comments

@chrhong
Copy link

chrhong commented Sep 20, 2022

Hi,

Does those reassemble example code forget to remove ethernet padding ?

assert(!send_packet(complete_datagram, out));

The padding is filled while ethernet frame too small which < 64bytes. Then zero padding is extended. Those padding should be removed manually while reassemble those fragments.

You can refer dpdk example:
https://github.com/DPDK/dpdk/blob/4a6672c2d301c105189ae74de73260af204c5ee8/lib/ip_frag/rte_ipv4_reassembly.c#L140

Br,
Christian

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant