You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix sdba Grouper.get_coordinate after xarray update (#2038)
<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
- This PR fixes#2037
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [ ] CHANGELOG.rst has been updated (with summary of main changes)
- [ ] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added
### What kind of change does this PR introduce?
* Uses a dumber way of getting the max doy, that doesn't rely on a
private xarray function. There is a public xarray function in >=2024.09,
but we still support >=2023.11.
### Does this PR introduce a breaking change?
Yes, only if a non-uniform calendar was used with a subset of years that
did not include a leap year. The max doy is now static (`standard =>
366`, for example) and not dynamic (`standard, 2004 => 366`).
0 commit comments