Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[🐞] qwikVite lint:true can slowdown development servers significantly #6837

Closed
maiieul opened this issue Aug 29, 2024 · 1 comment · Fixed by #7425
Closed

[🐞] qwikVite lint:true can slowdown development servers significantly #6837

maiieul opened this issue Aug 29, 2024 · 1 comment · Fixed by #7425
Assignees
@JerryWu1234 @dmitry-stepanenko @maiieul
Labels
COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it COMP: DX Developer Experience related issue TYPE: bug Something isn't working

Comments

@maiieul
Copy link
Contributor

maiieul commented Aug 29, 2024 •
edited
Loading

Which component is affected?

Qwik Rollup / Vite plugin

Describe the bug

On large codebases, starting the dev server can take a very long time and a quite a few seconds on code changes (no HMR).

Reproduction

🙅‍♂️

Steps to reproduce

No response

System Info

🙅‍♂️

Additional Information

Current workaround is to do

qwikVite({
   lint:false
})

Note: this setting does not affect your vscode eslint rules.

Until this is fixed, I suggest setting qwikVite plugin's lint to false by default so that people must set it to true in their Vite config for it to take effect.

You can add a thumbs up if you've experienced this issue and lint:false solved it for you.

If you don't want the qwikVite linter to be disabled by default, please leave a thumbs down and a comment :).
@maiieul maiieul added TYPE: bug Something isn't working STATUS-1: needs triage New issue which needs to be triaged COMP: DX Developer Experience related issue and removed STATUS-1: needs triage New issue which needs to be triaged labels Aug 29, 2024
@maiieul maiieul added the COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it label Aug 29, 2024
@intellix
Copy link
Contributor

intellix commented Aug 30, 2024 •
edited
Loading

For our project, initial start time:

  • enabled: 60sec (then vite says new dependencies optimised, and reloads for another 60 seconds so it's more like 2 minutes)
  • disabled: 10sec

I think also on refreshes and code changes it runs again? yesterday was painful working on something before I learned about this :) I think it was taking around 20 seconds on code changes yesterday before I disabled linting.

Our eslint extends:

  • sonarjs
  • unicorn
  • nx boundaries
  • qwik
  • prettier

We're happy with a really thorough/long linting process because we run it async in our CI/CD pipeline and disallow merges that fail it, so it's up to the developer to make sure it's 100% before he's ready to push. Ofc it would be nice to swap to biome and have it faster at some point.

I saw that there was work to swap from eslint to biome because it's much faster, but couldn't the linting be a separate vite plugin that can easily be seen and removed in our case?

Maybe it would be fine if only the qwik eslint plugin was used when using qwikVite({ lint: true })

@JerryWu1234 JerryWu1234 mentioned this issue Nov 6, 2024
Closed
@shairez shairez mentioned this issue Nov 14, 2024
Open
@JerryWu1234 JerryWu1234 mentioned this issue Mar 15, 2025
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from Upcoming to Done in Qwik Development Mar 25, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@JerryWu1234 JerryWu1234

@dmitry-stepanenko dmitry-stepanenko

@maiieul maiieul

Labels
COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it COMP: DX Developer Experience related issue TYPE: bug Something isn't working
Projects
Qwik Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set default value of lint to false to improve the execution per… JerryWu1234/qwik
4 participants
@intellix @JerryWu1234 @dmitry-stepanenko @maiieul