Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[🐞] onResolved cannot return a Promise #7086

Open
maiieul opened this issue Nov 22, 2024 · 2 comments · May be fixed by #7426
Open

[🐞] onResolved cannot return a Promise #7086

maiieul opened this issue Nov 22, 2024 · 2 comments · May be fixed by #7426
Assignees
@JerryWu1234
Labels
COMP: DX Developer Experience related issue COMP: typescript TYPE: bug Something isn't working

Comments

@maiieul
Copy link
Contributor

maiieul commented Nov 22, 2024 •
edited
Loading

Which component is affected?

Qwik Runtime

Describe the bug

Trying to await a function inside onResolved in a I get

Type '(appointments: MyCustomType) => Promise' is not assignable to type '(value: MyCustomType) => JSXOutput'.
Type 'Promise' is not assignable to type 'JSXOutput'.ts(2322)
core.d.ts(2280, 5): The expected type comes from property 'onResolved' which is declared here on type 'IntrinsicAttributes & ResourceProps'

But even though typescript complains, the code works on my end. So I guess it's just an easy fix on the ts side.

Reproduction

https://stackblitz.com/edit/github-b7kqvv?file=src%2Froutes%2Findex.tsx

Steps to reproduce

Open stackblitz repro, maybe edit the index.tsx file (add a space anywhere to get the ts highlighter).

System Info

🙅‍♂️

Additional Information

No response
@maiieul maiieul added TYPE: bug Something isn't working STATUS-1: needs triage New issue which needs to be triaged COMP: DX Developer Experience related issue COMP: typescript and removed STATUS-1: needs triage New issue which needs to be triaged labels Nov 22, 2024
@Varixo
Copy link
Member

Varixo commented Nov 23, 2024

This is probably fixed in v2 :D

@maiieul
Copy link
Contributor Author

maiieul commented Nov 26, 2024

Although the type fix is probably an easy fix in v1 too no?

@JerryWu1234 JerryWu1234 linked a pull request Mar 15, 2025 that will close this issue
Open
5 tasks
@JerryWu1234 JerryWu1234 self-assigned this Mar 15, 2025
@JerryWu1234 JerryWu1234 moved this from Backlog to Waiting For Review in Qwik Development Mar 19, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@JerryWu1234 JerryWu1234

Labels
COMP: DX Developer Experience related issue COMP: typescript TYPE: bug Something isn't working
Projects
Qwik Development
Status: Waiting For Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix a resource a type error when using async _resolved function JerryWu1234/qwik
3 participants
@JerryWu1234 @maiieul @Varixo