Specifix SQL Statements in Method leads to error

[bastianStr]

I have a method with the following SQL Statement in it:

    SELECT ( SUM( netwr ) + SUM( mwsbp ) ) AS order_amount
       FROM vbap
       WHERE vbeln = '1234567890'
       INTO @DATA(l_order_amount).

When I run ABAP Cleaner on it, i get a Parse error about "ENDMETHOD found but no corresponding METHOD". If I comment the SQL Statement, it works...

[fabianlupa]

I wonder if SELECT SINGLE makes any difference / sense?

[bastianStr]

I wonder if SELECT SINGLE makes any difference / sense?

SELECT SINGLE works, but then I cant SUM ;)

[fabianlupa]

I wonder if SELECT SINGLE makes any difference / sense?

SELECT SINGLE works, but then I cant SUM ;)

Have you tried? I don't think it makes a difference.

[bastianStr]

mmh, ok. You are right, it works. To be honest, I didn't expect this 😄

Ok, great. Problem half solved. At least for me.

This also works with ABAP Cleaner:

    SELECT 
      FROM vbap
      FIELDS ( SUM( netwr ) + SUM( mwsbp ) ) AS order_amount
      WHERE vbeln = '2004678933'
      INTO @DATA(l_order_amount).

[jmgrassau]

Hi bastianStr and Fabian,

thanks a lot for reporting and discussing this! This was a bug, because ABAP cleaner wrongly assumed that this SELECT requires an ENDSELECT (and therefore expected an ENDSELECT before the ENDMETHOD).

To determine whether or not SELECT opens a loop is not trivial, and in this case, ABAP cleaner got the arithmetic expression in parentheses wrong. Will be fixed in the next release!

It's nice that there is a workaround, but of course ABAP cleaner should be able to deal with anything that is correct ABAP syntax (well, apart from chain colons inside parentheses as in any_method( iv_value = : 1 ), 2 )., those are just too horrible ;-).

Kind regards,
Jörg-Michael

[jmgrassau]

Hi bastianStr,

thanks again for opening this issue! This should now be fixed with version 1.7.0, which was just released!

Kind regards,
Jörg-Michael