Align SELECT...FROM...JOIN

[JoachimEck]

Hey,

I think something is not rigth with the "Align SELECT ... FROM ... JOIN" rule. I was wondering why the Cleaner kept messing up the formatting in a SELECT.
I'm using version 1.16.2.

1. align AS always seems to be done, regardless of the checkbox

2. if I turn on the checkbox for the "Align ON", then it moves the ON behind the upper ON condition. If the checkbox is off, then it does what I would have expected if the checkbox was on

Maybe I just misinterpreted the options and everything is as it should be 😄

 SELECT *
      FROM test
           JOIN join_one ON test~aufnr = jo~aufnr
           JOIN join_two 		
		    			ON  test~aufnr = jt~aufnr
										AND test~werks = jt~werks
      INTO CORRESPONDING FIELDS OF TABLE @lt_table. 

Here is my profile: profile.zip

Best regards,
Joachim

[jmgrassau]

Hi Joachim,

thanks a lot for reporting this – ABAP cleaner didn't correctly determine the end of first the logical expressions here (ON …), which only happened if it was followed by JOIN (rather than INNER JOIN, LEFT|RIGHT OUTER JOIN, CROSS JOIN). This will be fixed with the next release, and with that, the options should work as expected.

Kind regards,
Jörg-Michael

[jmgrassau]

Hi Joachim,

thanks again for reporting this issue – this should now be fixed with version 1.18.0, which was just released!

Kind regards,
Jörg-Michael