Skip to content

Feature Request: Alignment for RAISE EVENT statements #377

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
StefanRutzmoser opened this issue Nov 12, 2024 · 3 comments
Closed

Feature Request: Alignment for RAISE EVENT statements #377

StefanRutzmoser opened this issue Nov 12, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@StefanRutzmoser
Copy link

The new feature should align the code similar to what it does for CALL METHOD. But examples are better than describing it in words:

Before cleanup:

RAISE EVENT message
EXPORTING
iv_id = 'MSG_ID'
iv_type = 'E'
iv_number = '001'.

After cleanup:

RAISE EVENT message
  EXPORTING
    iv_id     = 'MSG_ID'
    iv_type   = 'E'
    iv_number = '001'.

Optionally put the EXPORTING in the line of the statement:

RAISE EVENT message EXPORTING
  iv_id     = 'MSG_ID'
  iv_type   = 'E'
  iv_number = '001'.

I'm not sure if a new rule is needed for this or it could/should be added to the existing "Align parameters and components" rule.

@jmgrassau jmgrassau added the enhancement New feature or request label Dec 6, 2024
@jmgrassau
Copy link
Member

Hi Stefan,

perfect, very nice enhancement of the "Align parameters and components" rule!

Kind regards,
Jörg-Michael

@jmgrassau
Copy link
Member

Hi Stefan,

this was literally one added line of code! The layout simply follows the options for procedural calls (same as CALL METHOD, CREATE OBJECT, RECEIVE RESULTS, RAISE EXCEPTION, and RAISE SHORTDUMP):

image

image

Kind regards,
Jörg-Michael

@jmgrassau
Copy link
Member

Hi Stefan,

thanks for the inspiration! This alignment should work now with version 1.21.0, which was just released!

Kind regards,
Jörg-Michael

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants