Skip to content

"Align parameters and components": Direct usage of structure looks weird in VALUE #70

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
ConjuringCoffee opened this issue Jun 29, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ConjuringCoffee
Copy link
Contributor

Here's an example I don't want the ABAP Cleaner to change any further:

    DATA line_1 TYPE bapiret2.
    DATA table_1 TYPE bapiret2_t.

    table_1 = VALUE #( ( line_1 )
                       ( log_msg_no = '1' ) ).

Unfortunately, the ABAP Cleaner aligns the structure to the other assignments:

    DATA line_1 TYPE bapiret2.
    DATA table_1 TYPE bapiret2_t.

    table_1 = VALUE #( (              line_1 )
                       ( log_msg_no = '1' ) ).

Is this on purpose? If it is, can we please get an option to turn it off? 😊

Here are the settings I use:

image

@jmgrassau jmgrassau added the bug Something isn't working label Jun 29, 2023
@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

ah, nice example, I'm afraid this was simply not considered yet!

Kind regards,
Jörg-Michael

@jmgrassau
Copy link
Member

P.S.: And I can't imagine anyone wanting the current behavior, so I think this could be fixed without an additional option :-)

@jmgrassau jmgrassau self-assigned this Jun 30, 2023
@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

okay, this should be fixed in the next release!

Kind regards,
Jörg-Michael

@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

this fix is now released with version 1.5.0!

Kind regards,
Jörg-Michael

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants