fix: ip v4 filter typo and also clippy warnings

cavivie · cavivie · commit e8685945aa49 · 2024-04-14T13:14:09.000+08:00
diff --git a/src/filter.rs b/src/filter.rs
@@ -23,7 +23,7 @@ impl<'a> IpFilters<'a> {
         macro_rules! non_broadcast {
             ($addr:ident) => {
                 match $addr {
-                    IpAddr::V4(a) => !(a.is_broadcast() || a.is_multicast() || a.is_multicast()),
+                    IpAddr::V4(a) => !(a.is_broadcast() || a.is_multicast() || a.is_unspecified()),
                     IpAddr::V6(a) => !(a.is_multicast() || a.is_unspecified()),
                 }
             };
@@ -47,7 +47,7 @@ impl<'a> IpFilters<'a> {
     }
 
     pub fn add_all<I: IntoIterator<Item = IpFilter<'a>>>(&mut self, filters: I) {
-        self.filters.extend(filters.into_iter());
+        self.filters.extend(filters);
     }
 
     pub fn is_allowed(&self, src: &IpAddr, dst: &IpAddr) -> bool {

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ impl<'a> IpFilters<'a> {`
`23`	`23`	`macro_rules! non_broadcast {`
`24`	`24`	`($addr:ident) => {`
`25`	`25`	`match $addr {`
`26`		`- IpAddr::V4(a) => !(a.is_broadcast() \|\| a.is_multicast() \|\| a.is_multicast()),`
	`26`	`+ IpAddr::V4(a) => !(a.is_broadcast() \|\| a.is_multicast() \|\| a.is_unspecified()),`
`27`	`27`	`IpAddr::V6(a) => !(a.is_multicast() \|\| a.is_unspecified()),`
`28`	`28`	`}`
`29`	`29`	`};`
`@@ -47,7 +47,7 @@ impl<'a> IpFilters<'a> {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`pub fn add_all<I: IntoIterator<Item = IpFilter<'a>>>(&mut self, filters: I) {`
`50`		`- self.filters.extend(filters.into_iter());`
	`50`	`+ self.filters.extend(filters);`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`pub fn is_allowed(&self, src: &IpAddr, dst: &IpAddr) -> bool {`