Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Eslint rule react-hooks/exhaustive-deps questions on having response as depency #384

Open
iqoOopi opened this issue Feb 16, 2023 · 1 comment

Comments

@iqoOopi
Copy link

iqoOopi commented Feb 16, 2023

          > Try passing `response` into `useEffect`

Hi @alex-cory , got the same question. I'm wondering why adding response to useEffect/useCallback dependency won't cause re-render?

Let's say I have three api calls inside the componet

 const { loading, response, get, put } = useFetch();
  const call1= useCallback(async () => {

    const data= await get('endpoint1');
    if (response.ok) {
         
    }
  }, [get, response]);

  const call2= useCallback(async () => {

    const data= await get('endpoint2');
    if (response.ok) {
         
    }
  }, [get, response]);

  useEffect(() => {
    call2();
  }, [call2]);

when Call1 fired, the response will be changing, thus will cause a re-render on call2 thus then useEffect will be called again?

Originally posted by @iqoOopi in #87 (comment)

@iamthesiz
Copy link
Collaborator

try passing response.ok to dependency array

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants