Skip to content

Commit 33d4e52

Browse files
authored
Ensure messages are deduplicated based on model id (#205)
* Ensure messages are deduplicated based on model id * Fix types
1 parent 58e8954 commit 33d4e52

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/widgets.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ type DocumentChangedEvent = any
1717
type Receiver = any
1818
type Fragment = any
1919
type HasProps = any
20-
type Ref = any
2120

2221
const { keys, values } = Object
2322

@@ -29,6 +28,10 @@ export type RenderBundle = {
2928
div: string
3029
}
3130

31+
export interface Ref {
32+
id: string
33+
}
34+
3235
export interface DocumentChanged {
3336
event: 'jsevent'
3437
kind: string
@@ -37,7 +40,7 @@ export interface DocumentChanged {
3740
export interface ModelChanged extends DocumentChanged {
3841
event: 'jsevent'
3942
kind: 'ModelChanged'
40-
id: string
43+
model: Ref
4144
new: unknown
4245
attr: string
4346
}
@@ -169,7 +172,7 @@ export class BokehView extends DOMWidgetView {
169172
if (new_msg.kind != msg.kind) {
170173
new_msgs.push(msg)
171174
} else if (msg.kind == 'ModelChanged' && new_msg.kind == 'ModelChanged') {
172-
if (msg.id != new_msg.id || msg.attr != new_msg.attr) {
175+
if (msg.model.id != new_msg.model.id || msg.attr != new_msg.attr) {
173176
new_msgs.push(msg)
174177
}
175178
} else if (msg.kind == 'MessageSent' && new_msg.kind == 'MessageSent') {

0 commit comments

Comments
 (0)