Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Wrong peer_name #3

Open
tsouza opened this issue Jan 3, 2013 · 1 comment
Open

Wrong peer_name #3

tsouza opened this issue Jan 3, 2013 · 1 comment

Comments

@tsouza
Copy link

tsouza commented Jan 3, 2013

Hello,

It seems that peer_name is wrong when ip_to_bind is passed.

At gossiper.js:35 shouldn't it be? (as there is no address property)

this.peer_name    = [this.ip_to_bind, this.port.toString()].join(':');

Cheers

@snoj
Copy link

snoj commented Jan 16, 2013

I've just assigned the address property manually when specifying an ip to bind to.

var Gossiper = require('./node-gossip/index.js').Gossiper
var g = new Gossiper(9000, [], '192.168.1.1');
g.address = '8.8.8.8';
g.start();

The code does seem to assume that whatever you're binding to can be routed to from any peers.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants