Skip to content

Commit 787f021

Browse files
committed
btrfs: rename __btrfs_tree_lock() and __btrfs_tree_read_lock()
The __btrfs_tree_lock() and __btrfs_tree_read_lock() are using a naming with a double underscore prefix, which is specially not proper for exported functions. Remove the double underscore prefix from their name and add the "_nested" suffix. Reviewed-by: Anand Jain <anand.jain@oracle.com> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Reviewed-by: Qu Wenruo <wqu@suse.com> Signed-off-by: Filipe Manana <fdmanana@suse.com>
1 parent b4e48ed commit 787f021

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

fs/btrfs/ctree.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1003,7 +1003,7 @@ static noinline int balance_level(struct btrfs_trans_handle *trans,
10031003
goto out;
10041004
}
10051005

1006-
__btrfs_tree_lock(left, BTRFS_NESTING_LEFT);
1006+
btrfs_tree_lock_nested(left, BTRFS_NESTING_LEFT);
10071007
wret = btrfs_cow_block(trans, root, left,
10081008
parent, pslot - 1, &left,
10091009
BTRFS_NESTING_LEFT_COW);
@@ -1021,7 +1021,7 @@ static noinline int balance_level(struct btrfs_trans_handle *trans,
10211021
goto out;
10221022
}
10231023

1024-
__btrfs_tree_lock(right, BTRFS_NESTING_RIGHT);
1024+
btrfs_tree_lock_nested(right, BTRFS_NESTING_RIGHT);
10251025
wret = btrfs_cow_block(trans, root, right,
10261026
parent, pslot + 1, &right,
10271027
BTRFS_NESTING_RIGHT_COW);
@@ -1205,7 +1205,7 @@ static noinline int push_nodes_for_insert(struct btrfs_trans_handle *trans,
12051205
if (IS_ERR(left))
12061206
return PTR_ERR(left);
12071207

1208-
__btrfs_tree_lock(left, BTRFS_NESTING_LEFT);
1208+
btrfs_tree_lock_nested(left, BTRFS_NESTING_LEFT);
12091209

12101210
left_nr = btrfs_header_nritems(left);
12111211
if (left_nr >= BTRFS_NODEPTRS_PER_BLOCK(fs_info) - 1) {
@@ -1265,7 +1265,7 @@ static noinline int push_nodes_for_insert(struct btrfs_trans_handle *trans,
12651265
if (IS_ERR(right))
12661266
return PTR_ERR(right);
12671267

1268-
__btrfs_tree_lock(right, BTRFS_NESTING_RIGHT);
1268+
btrfs_tree_lock_nested(right, BTRFS_NESTING_RIGHT);
12691269

12701270
right_nr = btrfs_header_nritems(right);
12711271
if (right_nr >= BTRFS_NODEPTRS_PER_BLOCK(fs_info) - 1) {
@@ -3267,7 +3267,7 @@ static int push_leaf_right(struct btrfs_trans_handle *trans, struct btrfs_root
32673267
if (IS_ERR(right))
32683268
return PTR_ERR(right);
32693269

3270-
__btrfs_tree_lock(right, BTRFS_NESTING_RIGHT);
3270+
btrfs_tree_lock_nested(right, BTRFS_NESTING_RIGHT);
32713271

32723272
free_space = btrfs_leaf_free_space(right);
32733273
if (free_space < data_size)
@@ -3483,7 +3483,7 @@ static int push_leaf_left(struct btrfs_trans_handle *trans, struct btrfs_root
34833483
if (IS_ERR(left))
34843484
return PTR_ERR(left);
34853485

3486-
__btrfs_tree_lock(left, BTRFS_NESTING_LEFT);
3486+
btrfs_tree_lock_nested(left, BTRFS_NESTING_LEFT);
34873487

34883488
free_space = btrfs_leaf_free_space(left);
34893489
if (free_space < data_size) {

fs/btrfs/extent-tree.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5093,7 +5093,7 @@ btrfs_init_new_buffer(struct btrfs_trans_handle *trans, struct btrfs_root *root,
50935093
*/
50945094
btrfs_set_buffer_lockdep_class(lockdep_owner, buf, level);
50955095

5096-
__btrfs_tree_lock(buf, nest);
5096+
btrfs_tree_lock_nested(buf, nest);
50975097
btrfs_clear_buffer_dirty(trans, buf);
50985098
clear_bit(EXTENT_BUFFER_STALE, &buf->bflags);
50995099
clear_bit(EXTENT_BUFFER_ZONED_ZEROOUT, &buf->bflags);

fs/btrfs/locking.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,14 +129,14 @@ static void btrfs_set_eb_lock_owner(struct extent_buffer *eb, pid_t owner) { }
129129
*/
130130

131131
/*
132-
* __btrfs_tree_read_lock - lock extent buffer for read
132+
* btrfs_tree_read_lock_nested - lock extent buffer for read
133133
* @eb: the eb to be locked
134134
* @nest: the nesting level to be used for lockdep
135135
*
136136
* This takes the read lock on the extent buffer, using the specified nesting
137137
* level for lockdep purposes.
138138
*/
139-
void __btrfs_tree_read_lock(struct extent_buffer *eb, enum btrfs_lock_nesting nest)
139+
void btrfs_tree_read_lock_nested(struct extent_buffer *eb, enum btrfs_lock_nesting nest)
140140
{
141141
u64 start_ns = 0;
142142

@@ -193,7 +193,7 @@ void btrfs_tree_read_unlock(struct extent_buffer *eb)
193193
*
194194
* Returns with the eb->lock write locked.
195195
*/
196-
void __btrfs_tree_lock(struct extent_buffer *eb, enum btrfs_lock_nesting nest)
196+
void btrfs_tree_lock_nested(struct extent_buffer *eb, enum btrfs_lock_nesting nest)
197197
__acquires(&eb->lock)
198198
{
199199
u64 start_ns = 0;

fs/btrfs/locking.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,20 +163,20 @@ enum btrfs_lockdep_trans_states {
163163
static_assert(BTRFS_NESTING_MAX <= MAX_LOCKDEP_SUBCLASSES,
164164
"too many lock subclasses defined");
165165

166-
void __btrfs_tree_lock(struct extent_buffer *eb, enum btrfs_lock_nesting nest);
166+
void btrfs_tree_lock_nested(struct extent_buffer *eb, enum btrfs_lock_nesting nest);
167167

168168
static inline void btrfs_tree_lock(struct extent_buffer *eb)
169169
{
170-
__btrfs_tree_lock(eb, BTRFS_NESTING_NORMAL);
170+
btrfs_tree_lock_nested(eb, BTRFS_NESTING_NORMAL);
171171
}
172172

173173
void btrfs_tree_unlock(struct extent_buffer *eb);
174174

175-
void __btrfs_tree_read_lock(struct extent_buffer *eb, enum btrfs_lock_nesting nest);
175+
void btrfs_tree_read_lock_nested(struct extent_buffer *eb, enum btrfs_lock_nesting nest);
176176

177177
static inline void btrfs_tree_read_lock(struct extent_buffer *eb)
178178
{
179-
__btrfs_tree_read_lock(eb, BTRFS_NESTING_NORMAL);
179+
btrfs_tree_read_lock_nested(eb, BTRFS_NESTING_NORMAL);
180180
}
181181

182182
void btrfs_tree_read_unlock(struct extent_buffer *eb);

0 commit comments

Comments
 (0)