Skip to content

WorkerActivitiesPerSecond does not work #553

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
sokada1221 opened this issue Oct 22, 2020 · 1 comment · May be fixed by #557
Open

WorkerActivitiesPerSecond does not work #553

sokada1221 opened this issue Oct 22, 2020 · 1 comment · May be fixed by #557

Comments

@sokada1221
Copy link
Contributor

sokada1221 commented Oct 22, 2020 •
edited
Loading

Describe the bug
Setting workerActivitiesPerSecond via setWorkerActivitiesPerSecond() does not perform any rate limiting.

To Reproduce
Is the issue reproducible?

  • Yes

Steps to reproduce the behavior:

  1. Write and run a workflow with rate limited Activity worker via setWorkerActivitiesPerSecond()
  2. No rate limiting is performed at worker-level.

Expected behavior
WorkerActivitiesPerSecond to work according to the documentation.

Screenshots
N/A

Additional context
N/A
@sokada1221
Copy link
Contributor Author

Root cause:
Took a quick look at Worker implementation. Seems like workerActivitiesPerSecond isn't used anywhere i.e. missing the implementation.

Will work on the missing implementation.

@sokada1221 sokada1221 mentioned this issue Oct 23, 2020
Closed
@sokada1221 sokada1221 changed the title MaxWorkerActivitiesPerSecond does not work WorkerActivitiesPerSecond does not work Oct 23, 2020
@sokada1221 sokada1221 linked a pull request Oct 23, 2020 that will close this issue
Open
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement WorkerActivitiesPerSecond sokada1221/cadence-java-client
1 participant
@sokada1221