Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CIP-119 should not specify maximum character lengths. #975

Open
Quantumplation opened this issue Jan 29, 2025 · 1 comment
Open

CIP-119 should not specify maximum character lengths. #975

Quantumplation opened this issue Jan 29, 2025 · 1 comment

Comments

@Quantumplation
Copy link
Contributor

In my opinion, it should not be the responsibility of the CIP to specify a maximum character length as part of the spec; or, at the very least, this should be dramatically increased. If an explorer wants to only store the first 1000 characters, and then provide a link to the full content hosted elsewhere, that would be an acceptable decision of the tool, but should not be an imposition imposed by the specification. In particular, 1000 characters is extremely limiting.

@MadOrkestra
Copy link
Contributor

100%

I'll leave this here, because it is most likely related: I was trying to figure out why the HF governance proposal was creating a hash mismatch in db-sync and would therefore not be included as metadata json in endpoints on Koios. Turns out db-sync enforces a way too low character limit on governance action metadata:
IntersectMBO/cardano-db-sync#1928 (comment)

The CIP119 limit was probably set for a similar reason.

Maybe it is time to rethink how to handle off-chain metadata and if it needs to be in db-sync at all?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants