fix: improve logging of errors (closes DELO-4986) (#121)

* fix: serialize errors array to string

* better error handling

* better error handling

Author: lukaszczerpak-cloudinary

cloudinary/apiCaller.js

@@ -79,10 +79,12 @@ const sendToCloudinary = (imagesArray, batchSize, dpr, metaData, quality, cb, ro
             analyzeResults.push(result);
             callback();
           }
-        });
+        }).catch(error => {
+          logger.error('cloudinary upload error', error, rollBarMsg);
+    });
   }, err => {
     if (uploadErrors.length > 0) {
-      logger.error('cloudinary upload errors', uploadErrors, rollBarMsg);
+      logger.error(`cloudinary upload errors: ${uploadErrors.length} issues`, rollBarMsg);
     }
     if (err) {
       cb({

package.json

@@ -9,13 +9,13 @@
   },
   "dependencies": {
     "@opentelemetry/api": "^1.9.0",
-    "@opentelemetry/exporter-prometheus": "^0.57.1",
-    "@opentelemetry/instrumentation-express": "^0.47.0",
-    "@opentelemetry/instrumentation-http": "^0.57.1",
+    "@opentelemetry/exporter-prometheus": "^0.57.2",
+    "@opentelemetry/instrumentation-express": "^0.47.1",
+    "@opentelemetry/instrumentation-http": "^0.57.2",
     "@opentelemetry/resources": "^1.30.1",
-    "@opentelemetry/sdk-node": "^0.57.1",
+    "@opentelemetry/sdk-node": "^0.57.2",
     "@opentelemetry/sdk-trace-base": "^1.30.1",
-    "@opentelemetry/semantic-conventions": "^1.29.0",
+    "@opentelemetry/semantic-conventions": "^1.30.0",
     "async": "^3.2.6",
     "async-mutex": "^0.5.0",
     "bytes": "^3.1.2",
@@ -36,7 +36,7 @@
     "chai-http": "^4.4.0",
     "husky": "^9.1.7",
     "mocha": "^11.1.0",
-    "nock": "^14.0.0",
+    "nock": "^14.0.1",
     "patch-package": "^8.0.0",
     "sinon": "^19.0.2",
     "sinon-chai": "^3.7.0"

wtp/apiCaller.js

@@ -84,7 +84,6 @@ const runWtpTest = async (url, mobile, cb) => {
   let rollBarMsg = {testId: "", analyzedUrl: url, thirdPartyErrorCode: "", thirdPartyErrorMsg: "", file: path.basename((__filename))};
   try {
     response = await got(options);
-    logger.info("Started WPT test");
     const {statusCode, body} = response;
     if (statusCode !== 200) {
       rollBarMsg.thirdPartyErrorCode = response.statusCode;
@@ -100,6 +99,7 @@ const runWtpTest = async (url, mobile, cb) => {
     rollBarMsg.testId = (typeof bodyJson.data !== 'undefined' && typeof bodyJson.data.testId !== 'undefined') ?
         (bodyJson.data.testId) :
         "N/A";
+    logger.info("Started WPT test", {"testId": rollBarMsg.testId});
     let testId = resultParser.parseTestResponse(bodyJson, rollBarMsg);
     if (typeof testId === 'object') {
       cb(null, testId);