Skip to content

Commit fe3da81

Browse files
fix: lcp incorrectly handled in results parser (#71)
1 parent 7f408bb commit fe3da81

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

cloudinary/apiCaller.js

+8-6
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,14 @@ const sendToCloudinary = (imagesArray, batchSize, dpr, metaData, quality, cb, ro
100100
}
101101
// move lcp
102102
const lcpIdx = parsed.imagesTestResults.findIndex((i) => i.tags.includes('lcp'));
103-
metaData.lcp = {
104-
isImage: metaData.lcpEvent.type === 'image',
105-
analyzed: parsed.imagesTestResults.splice(lcpIdx, 1)[0],
106-
event: metaData.lcpEvent,
107-
};
108-
delete (metaData.lcpEvent);
103+
if (lcpIdx >= 0) {
104+
metaData.lcp = {
105+
isImage: metaData.lcpEvent.type === 'image',
106+
analyzed: parsed.imagesTestResults.splice(lcpIdx, 1)[0],
107+
event: metaData.lcpEvent,
108+
};
109+
delete (metaData.lcpEvent);
110+
}
109111
Object.assign(parsed.resultSumm, metaData);
110112
cb(null, {status: 'success', data: parsed});
111113
});

0 commit comments

Comments
 (0)