Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Ignore and delete old versions when copying plugins #169

Closed
hlxid opened this issue Feb 22, 2020 · 0 comments
Closed

Ignore and delete old versions when copying plugins #169

hlxid opened this issue Feb 22, 2020 · 0 comments
Assignees
Labels
bug Something isn't working build Requires changes to the build system minor Quick to implement

Comments

@hlxid
Copy link
Member

hlxid commented Feb 22, 2020

Description

When the version of a plugin is bumped it will exist twice in the plugins directory because the file with the old version number will still be in the plugins directory. ChatOverflow will load both versions and use the one first loaded which mostly the old version because it is loaded alphabetically and people will wonder why their changes won't take effect.

If people still copy an old version manually into the directory in e.g. the end-user deployment the framework should always use the newer version and warn that there are two versions installed.

How to reproduce

  1. Have a plugin and starting ChatOverflow to copy it to the plugin directory.
  2. Bump the version and restart ChatOverflow to copy the new version
  3. The old plugin is still in the plugins directory and will still be used.

Refrences

@derNiklaas suffering from this on discord.

@hlxid hlxid added bug Something isn't working minor Quick to implement build Requires changes to the build system labels Feb 22, 2020
@hlxid hlxid added this to the alpha 1 (4.0.0) milestone Feb 22, 2020
@hlxid hlxid self-assigned this Feb 22, 2020
@hlxid hlxid closed this as completed Mar 8, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug Something isn't working build Requires changes to the build system minor Quick to implement
Projects
None yet
Development

No branches or pull requests

1 participant