Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Make requirements read-only for plugin developers #79

Closed
sebinside opened this issue Jul 9, 2019 · 1 comment
Closed

Make requirements read-only for plugin developers #79

sebinside opened this issue Jul 9, 2019 · 1 comment
Assignees
@sebinside
Labels
api Requires api changes enhancement New feature or request minor Quick to implement
Milestone
pre-alpha 3

Comments

@sebinside
Copy link
Member

Description

Because of the current API design, it possible to the plugin dev to edit or unset a retrieved requirement. This is not intended. The addRequirement should be reworked to only return a container with the requirement reference and possible getters.

References

https://github.com/codeoverflow-org/chatoverflow-api/blob/702cf575556b162875b808b5d55d166bb2250752/src/main/java/org/codeoverflow/chatoverflow/api/plugin/configuration/Requirements.java#L57
@sebinside sebinside added enhancement New feature or request minor Quick to implement api Requires api changes labels Jul 9, 2019
@sebinside sebinside added this to the pre-alpha 3 milestone Jul 9, 2019
@sebinside sebinside self-assigned this Jul 9, 2019
@sebinside sebinside mentioned this issue Jul 22, 2019
Closed
6 tasks
@sebinside
Copy link
Member Author

sebinside commented Jul 29, 2019 •
edited
Loading

Closed with a25d1c2 and codeoverflow-org/chatoverflow-api@3133d80.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@sebinside sebinside

Labels
api Requires api changes enhancement New feature or request minor Quick to implement
Projects
None yet
Milestone
pre-alpha 3
Development

No branches or pull requests
1 participant
@sebinside