Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Escape plugin names in plugins.sbt #94

Closed
sebinside opened this issue Jul 21, 2019 · 2 comments
Closed

Escape plugin names in plugins.sbt #94

sebinside opened this issue Jul 21, 2019 · 2 comments
Labels
enhancement New feature or request minor Quick to implement
Milestone
pre-alpha 3

Comments

@sebinside
Copy link
Member

Description

We could use the backtick-notation to enable more plugin naming possibilities. e.g. naming a plugin private causes an error in the plugins.sbt right now. This might also solve the hyphen-problem.
@sebinside sebinside added enhancement New feature or request minor Quick to implement labels Jul 21, 2019
@sebinside sebinside added this to the pre-alpha 3 milestone Jul 21, 2019
@sebinside
Copy link
Member Author

Probably interesting for @daniel0611 :D

@hlxid
Copy link
Member

hlxid commented Jul 21, 2019

Will pr it sometime today. Note that java doesn't provide a way to escape class names, meaning we also need to filter out illegal characters anyway like I did in ff66784 for hyphens. Still a valid fix for keywords though.

@hlxid hlxid mentioned this issue Jul 21, 2019
Merged
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
enhancement New feature or request minor Quick to implement
Projects
None yet
Milestone
pre-alpha 3
Development

No branches or pull requests
2 participants
@sebinside @hlxid