Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PHPUnit 10 support #455

Closed
jdecool opened this issue Feb 10, 2023 · 0 comments · Fixed by #456
Closed

PHPUnit 10 support #455

jdecool opened this issue Feb 10, 2023 · 0 comments · Fixed by #456

Comments

@jdecool
Copy link
Contributor

jdecool commented Feb 10, 2023

PHPUnit 10 was released few days ago and it's now fully tped.

So the Coduo\PHPMatcher\PHPUnit\PHPMatcherConstraint will not work anymore because override methods are not compatible with the parent class.

An error message from my CI:

[2023-02-10T16:27:49.903408+01:00] php.CRITICAL: Fatal Compile Error: Declaration of Coduo\PHPMatcher\PHPUnit\PHPMatcherConstraint::fail($other, $description, ?SebastianBergmann\Comparator\ComparisonFailure $comparisonFailure = null): void must be compatible with PHPUnit\Framework\Constraint\Constraint::fail(mixed $other, string $description, ?SebastianBergmann\Comparator\ComparisonFailure $comparisonFailure = null): never {"exception":"[object] (Symfony\\Component\\ErrorHandler\\Error\\FatalError(code: 0): Compile Error: Declaration of Coduo\\PHPMatcher\\PHPUnit\\PHPMatcherConstraint::fail($other, $description, ?SebastianBergmann\\Comparator\\ComparisonFailure $comparisonFailure = null): void must be compatible with PHPUnit\\Framework\\Constraint\\Constraint::fail(mixed $other, string $description, ?SebastianBergmann\\Comparator\\ComparisonFailure $comparisonFailure = null): never at /var/www/project/vendor/coduo/php-matcher/src/PHPUnit/PHPMatcherConstraint.php:61)"} []

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant