Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consider upgrade doctrine/lexer to 2.x branch #457

Closed
jdecool opened this issue Feb 11, 2023 · 3 comments
Closed

Consider upgrade doctrine/lexer to 2.x branch #457

jdecool opened this issue Feb 11, 2023 · 3 comments

Comments

@jdecool
Copy link
Contributor

jdecool commented Feb 11, 2023

There's two new major branch of doctrine/lexer.

We can consider to switch to 2.0 branch as its dependencies do not result in BC.

Currently we can have issue installing php-matcher with some recent dependencies which are not compatible with doctrine/lexer 1 (I think about latest version of friendsofphp/php-cs-fixer).

@norberttech
Copy link
Member

If possible, I think I would like to support doctrine/lexer: ^1||^2 versions, if not ^2 can go to 6.x as it will be anyway released as 6.1.0

@norberttech
Copy link
Member

#458

@jdecool
Copy link
Contributor Author

jdecool commented Feb 14, 2023

Great!

Thanks

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants