-
Notifications
You must be signed in to change notification settings - Fork 771
[lib] Replace uses of add_meow_t
with plain cv-qualifiers
#7851
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
...except for [tab:meta.trans.cv]. Because the wording change for `add_cv` seems a bit non-trivial.
There may be additional uses of |
Those should not be in this pull request. |
Other uses of For |
source/utilities.tex
Outdated
@@ -63,7 +63,7 @@ | |||
|
|||
// \ref{utility.as.const}, \tcode{as_const} | |||
template<class T> | |||
constexpr add_const_t<T>& as_const(T& t) noexcept; | |||
constexpr const T& as_const(T& t) noexcept; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the mangled name for std::as_const
specializations, but I don't think we need to care about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a normative change though, so not editorial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood; @frederick-vs-ja , please remove this change from the present editorial pull request and (at your option) create an LWG issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted.
...except for [tab:meta.trans.cv]. Because the wording change for
add_cv
seems a bit non-trivial.Fixes #7845.