Merge pull request #9 from cypress-io/issue-8-silent-errors

Fix silent errors

Author: chrisbreiding

index.js

@@ -92,24 +92,30 @@ const preprocessor = (options = {}) => {
     // is invoked again with the same filePath
     bundles[filePath] = latestBundle.promise
 
+    const rejectWithErr = (err) => {
+      err.filePath = filePath
+      // backup the original stack before it's potentially modified by bluebird
+      err.originalStack = err.stack
+      log(`errored bundling ${outputPath}`, err)
+      latestBundle.reject(err)
+    }
+
     // this function is called when bundling is finished, once at the start
     // and, if watching, each time watching triggers a re-bundle
     const handle = (err, stats) => {
       if (err) {
-        err.filePath = filePath
-        // backup the original stack before it's
-        // potentially modified from bluebird
-        err.originalStack = err.stack
-        log(`errored bundling ${outputPath}`, err)
-        return latestBundle.reject(err)
+        return rejectWithErr(err)
       }
 
-      // these stats are really only useful for debugging
       const jsonStats = stats.toJson()
-      if (jsonStats.errors.length > 0) {
-        log(`soft errors for ${outputPath}`)
-        log(jsonStats.errors)
+
+      if (stats.hasErrors()) {
+        err = new Error('Webpack Compilation Error')
+        err.stack = jsonStats.errors.join('\n\n')
+        return rejectWithErr(err)
       }
+
+      // these stats are really only useful for debugging
       if (jsonStats.warnings.length > 0) {
         log(`warnings for ${outputPath}`)
         log(jsonStats.warnings)

test/index_spec.js

@@ -32,6 +32,7 @@ describe('webpack preprocessor', function () {
     webpack.returns(this.compilerApi)
 
     this.statsApi = {
+      hasErrors () { return false },
       toJson () { return { warnings: [], errors: [] } },
     }
 
@@ -168,13 +169,25 @@ describe('webpack preprocessor', function () {
         }
       })
 
-      it('it rejects with error', function () {
+      it('it rejects with error when an err', function () {
         this.compilerApi.run.yields(this.err)
         return this.run().catch((err) => {
           expect(err.stack).to.equal(this.err.stack)
         })
       })
 
+      it('it rejects with joined errors when a stats err', function () {
+        const errs = ['foo', 'bar', 'baz']
+        this.statsApi = {
+          hasErrors () { return true },
+          toJson () { return { errors: errs } },
+        }
+        this.compilerApi.run.yields(null, this.statsApi)
+        return this.run().catch((err) => {
+          expect(err.stack).to.equal(errs.join('\n\n'))
+        })
+      })
+
       it('backs up stack as originalStack', function () {
         this.compilerApi.run.yields(this.err)
         return this.run().catch((err) => {