Skip to content

Goal: v1.0 proper #4

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
5 of 11 tasks
coolaj86 opened this issue Dec 31, 2022 · 1 comment
Open
5 of 11 tasks

Goal: v1.0 proper #4

coolaj86 opened this issue Dec 31, 2022 · 1 comment

Comments

@coolaj86
Copy link
Member

coolaj86 commented Dec 31, 2022

  • Get a feel for the ergonomics, replace dashcore-lib in
  • bikeshed on names of things
    (pukkeyhash vs pukKeyHash, sighashType vs sigHashType)
  • getPrivateKey() in txInput?
  • a new DashUtxo vs CoreUtxo vs InsightUtxo
    • CoreUtxo, not DashUtxo (and all accompanying nomenclature)
    • satoshis, not units
  • subscript vs lockScript and sigScript?
  • publish v1.0.0 to npm

Dependencies

  • Secp256k1
  • DashKeys (basex, base58, base58check, ripemd160)
  • DashTx (~DashKeys)
  • DashHD

How to handle "change"

  • n*satoshis per byte
    • acceptable range is nsatoshisbytes to (n+1)satoshisbytes
  • if the leftover amount is less than minimum acceptable denomination or (n+1)*satoshis*bytes, pay it as the fee
    • otherwise throw an error
@coolaj86
Copy link
Member Author

coolaj86 commented Jan 16, 2023

Bikeshed

CoreUtxo vs InsightUtxo vs BlockUtxo

/**
 * CoreUtxo (as in BitCore / DashCore)
 * @typedef {Object} CoreUtxo
 * @property {String} txId
 * @property {Number} outputIndex
 * @property {String} address
 * @property {String} script
 * @property {Number} satoshis
 */

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant