Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Wallet UI - Refactoring - Dialog Internal State & Contact Creation #10

Closed
jojobyte opened this issue Nov 1, 2024 · 2 comments · May be fixed by dashhive/wallet-ui#76
Closed

Wallet UI - Refactoring - Dialog Internal State & Contact Creation #10

jojobyte opened this issue Nov 1, 2024 · 2 comments · May be fixed by dashhive/wallet-ui#76
Assignees
@jojobyte
Labels
enhancement New feature or request

Comments

@jojobyte
Copy link
Contributor

jojobyte commented Nov 1, 2024

More refactors building upon the last ones, to fix the internal state of several components, which were not correctly updating/resetting when some dialogs would close.

It also moves contact creation/updating out of the dialogs so that we can programatically create a contact without user interaction. This is particularly useful for creating a CrowdNode or Maya contact, where the user shouldn't need to know the Address/Contact information.
@jojobyte jojobyte moved this to Settled in Ledger Nov 1, 2024
@jojobyte jojobyte added this to Ledger Nov 1, 2024
@jojobyte jojobyte closed this as completed by moving to Settled in Ledger Nov 1, 2024
@jojobyte jojobyte self-assigned this Nov 1, 2024
@jojobyte jojobyte added the enhancement New feature or request label Nov 1, 2024
@jojobyte jojobyte linked a pull request Nov 1, 2024 that will close this issue
Refactor for CrowdNode 3rd party integration dashhive/wallet-ui#76
Open
@jojobyte jojobyte moved this from Settled to Unclaimed in Ledger Nov 1, 2024
@jojobyte jojobyte reopened this Nov 1, 2024
@jojobyte
Copy link
Contributor Author

jojobyte commented Nov 1, 2024

Claiming Task #10

Address: Xe415HRwb4B21qMBewfBsQLHbtkMvSkYe4

Demos:

Code:

@jojobyte jojobyte moved this from Unclaimed to Claimed in Ledger Nov 1, 2024
@jojobyte jojobyte moved this from Claimed to Approved in Ledger Nov 1, 2024
@jojobyte
Copy link
Contributor Author

jojobyte commented Nov 1, 2024

Approved.

@jojobyte jojobyte changed the title Refactoring - Wallet UI - 3rd Party Integration: CrowdNode UI Refactoring - Wallet UI - Dialog Internal State & Contact Creation Nov 1, 2024
@jojobyte jojobyte changed the title Refactoring - Wallet UI - Dialog Internal State & Contact Creation Wallet UI - Refactoring - Dialog Internal State & Contact Creation Nov 1, 2024
@jojobyte jojobyte moved this from Approved to Settled in Ledger Nov 1, 2024
@jojobyte jojobyte closed this as completed by moving to Settled in Ledger Nov 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jojobyte jojobyte

Labels
enhancement New feature or request
Projects
Ledger
Status: Settled
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor for CrowdNode 3rd party integration dashhive/wallet-ui
1 participant
@jojobyte