-
Notifications
You must be signed in to change notification settings - Fork 34
migrate from setup.py
to pyproject.toml
#287
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
If somebody wants to contribute a |
Pytorch can be used with Jax also shouldn't be a problem, and can nowadays even be used without https://github.com/jorenham/jax_pep503 If I remember correctly, I managed to get And I know for certain that That's all of the gpu-related stuff, right? |
I'll give it a try |
For sure, you can install and use GPU packages from PyPI. But there are various reasons why, especially from a development perspective, it is better to work with a package manager/distribution which is aware of native dependencies. There is more on this at https://pypackaging-native.github.io/key-issues/gpus/. |
Yea that makes sense. But in this project, does that really matter? |
I suppose it probably doesn't make a big difference, but just better to follow best practices given the choice 🤷♂️ |
Can this be closed by #255? |
Indeed, thanks @NeilGirdhar ! |
I'd also recommend
uv
forpyproject.toml
-based project management. That would also allow getting rid ofrequirements-dev.txt
, simplifying the project setup.But something tells me @lucascolley is going to bring up
pixie
as an alternative touv
.The text was updated successfully, but these errors were encountered: