Nitpicky logging change. #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace with "stderr output of" to ensure that folks know there's not an error. This was especially annoying when writing a wrapper around Hadoop components. They log everything to stderr, so I kept seeing "Error", even though everything was working fine.
|
Made a similar change for stdout and it turns out the tests were expecting that exact phrase. Updated them. Which makes me think maybe there should be a way to configure those strings, but that's for another time. Once this passes on Travis, I'll bump the version. Thanks! Hadoop! Crazy! Can't believe they don't insist on Python :) |
|
Awesome. Thanks Dave. lol. This whole time I was under the impression that Travis was a person and that Travis was really nitpicky about log messages. ^_^ |
|
build passing, this will be in the next release |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace "Error output of" with "stderr output of" to ensure that folks know there's not actually any error.
This was especially annoying when writing a wrapper around Hadoop components. They log everything to stderr, so I kept seeing "Error", even though everything was working fine.