Skip to content

[BUG] Circular Object. #38

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
adamchenwei opened this issue Oct 26, 2021 · 8 comments
Closed

[BUG] Circular Object. #38

adamchenwei opened this issue Oct 26, 2021 · 8 comments

Comments

@adamchenwei
Copy link

adamchenwei commented Oct 26, 2021

Describe the bug
I am seeing the CIRCULAR OBJECT , always in my last item of the events list and there is nowhere describe why its happening.
I saw several related issues, and an open PR.
Which supposedly address this issue? What is the issue exactly? Do we know why its kept recurring?

The open PR I see: #17
Other Same Issue Ref:
#32
#36
#28

Screen Shot 2021-10-26 at 2 50 30 PM

@JESii
Copy link

JESii commented Jul 7, 2022

FYI... I saw this when I stored an array of objects in my state:

asOfDateList: [{asOfDate: 123456789}, {asOfDate: 9876431005}, {asOfDate: 1112223334}, {asOfDate: 7778889990}]

I'm guessing the confusion was because of the repeated keys in the objects...?
In any event, I just converted to an array of numbers which is what I really wanted and that circular error message disappeared.

@JESii
Copy link

JESii commented Jul 8, 2022

Well... it's back again, in spite of my work to track / eliminate it.
@deeppatel234 -- what can be done about this? The questions that @adamchenwei asked are apropros:

  1. What exactly causes this situation? E.g., would an array of objects incorrectly trigger this response?
  2. What can be done to resolve this issue?
  3. And... how soon could we expect to see a resolution?
    thanks very much... the tool is very helpful and I'm hoping that this issue can be resolved soon.

@deeppatel234
Copy link
Owner

Hello @JESii

Thank you for reporting the issue. I will check the issue and let you know.

Thanks,
Deep

@JESii
Copy link

JESii commented Jul 8, 2022

Thanks, @deeppatel234. FYI I forked the code and searched for "CIRCULER" but was unable to find that anywhere. I did find the section of code where you check for circular structures, but your code specifically resolves down to:
return ${seen.get(v)};
That has the correct spelling... so I wonder where that message is actually coming from?

@deeppatel234
Copy link
Owner

Hello @JESii and @adamchenwei

Circular Object issue is now resolved in useReducer debug. commit 4317bc1

the commit will be release next week.

there will be a typo error in the prod extension. the actual text is "CIRCULAR". this is fixed in code but not released. you will find these changes in the next release.

Thanks,
Deep

@deeppatel234
Copy link
Owner

Will Close this issue when released in the store.

@JESii
Copy link

JESii commented Jul 24, 2022 via email

@deeppatel234
Copy link
Owner

@JESii @adamchenwei

issue is resolved and released in chrome and firefox web store

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants