Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Address settings in configMap should not be sorted by name #6

Open
wojtre opened this issue May 12, 2020 · 2 comments
Open

Address settings in configMap should not be sorted by name #6

wojtre opened this issue May 12, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wojtre
Copy link
Contributor

wojtre commented May 12, 2020

Some settings require other settings to be already defined. The address settings in configMap are always sorted by name so there is no way to define the required order of settings.
E.g.
redeliveryCollisionAvoidanceFactor require redeliveryDelay or redeliveryDelayMultiplier to be already defined but the settings from .values

  • match: "statesQueue"
    settings:
    redeliveryCollisionAvoidanceFactor: '0.15'
    redeliveryDelayMultiplier: '1.5'
    redeliveryDelay: '5000'
    maxRedeliveryDelay: '30000'
    maxDeliveryAttempts: '-1'

are expanded into

   <address-setting match="statesQueue">
    <max-delivery-attempts>-1</max-delivery-attempts>
    <max-redelivery-delay>30000</max-redelivery-delay>
    <redelivery-collision-avoidance-factor>0.15</redelivery-collision-avoidance-factor>
    <redelivery-delay>5000</redelivery-delay>
    <redelivery-delay-multiplier>1.5</redelivery-delay-multiplier>
   </address-setting>

This problem probably applies to other settings from configMap like clustering.xml or clustering.xml

@sflandergan
Copy link
Member

sflandergan commented May 12, 2020

Seems we have to make a breaking change and replace our map structures with slices.
Maps are always sorted by key within the go templates

@sflandergan
Copy link
Member

@wojtre do you want to contribute the change?

@marinabauer marinabauer added enhancement New feature or request good first issue Good for newcomers labels Jul 21, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants