Skip to content

Should we throw warning instead of error while patched packages not exist #339

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
joe223 opened this issue Aug 21, 2021 · 3 comments · May be fixed by #460
Open

Should we throw warning instead of error while patched packages not exist #339

joe223 opened this issue Aug 21, 2021 · 3 comments · May be fixed by #460

Comments

@joe223
Copy link

joe223 commented Aug 21, 2021 •
edited
Loading

As a example:

Patch file found for package vite which is not present at node_modules/vite

If we want to build sub-packages independently in monorepo, but we already set root/package.json

"scripts": {
   "postinstall": "patch-package"
 }

that will interrupt the build process if submodule root/packages/module-a does not dependent vite
@marcogigliarano
Copy link

Any update on this? I think I'm facing the same problem with another module.
I work with Lerna monorepo and this issue is just on Gitlab CI, locally it's working.

@nickfla1-mxm
Copy link

nickfla1-mxm commented Nov 11, 2021 •
edited
Loading

+1, would be a nice addition. A cli flag like --skip-not-found / --skip-missing, enabling it would just print a warning instead of an exception. Without it, it would default to the current behaviour.

@xziy
Copy link

xziy commented Aug 19, 2022 •
edited
Loading

+1

@andyjy andyjy linked a pull request Apr 1, 2023 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --ignore-missing flag to continue without error on missing packages andyjy/patch-package
4 participants
@marcogigliarano @joe223 @xziy @nickfla1-mxm