Skip to content

Have Suggest extensible #396

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
davidTurczi opened this issue Nov 22, 2013 · 2 comments
Closed

Have Suggest extensible #396

davidTurczi opened this issue Nov 22, 2013 · 2 comments

Comments

@davidTurczi
Copy link

Elastic supports completion suggestion as an experimental feature. I understand the point of not building experimental features into the client, but nonetheless I'd like to have the ability to extend this way myself.

SuggestDescriptorBucket has a fixed TermSuggest and PhraseSuggest property, please change it into a dictionary-like wrapper, so I can add ANY descriptor inheriting from BaseSuggestDescriptor (so I could implement my own CompletionSuggestDescriptor)

@gmarz
Copy link
Contributor

gmarz commented Nov 22, 2013

@davidTurczi

Completion suggestions were actually added in this PR: #376 and will probably be available in the next NuGeT release.

@davidTurczi
Copy link
Author

Ah that's great! I'll go instead and ask for #395 a new nuget :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants